Skip to content

Improve handling of OIDs#32

Merged
Schamper merged 3 commits intomainfrom
improve-oid
Feb 19, 2026
Merged

Improve handling of OIDs#32
Schamper merged 3 commits intomainfrom
improve-oid

Conversation

@Schamper
Copy link
Member

@Schamper Schamper commented Feb 17, 2026

Fixes #22 and #35.

Removed reliance on OID for core parsing, and added support for custom defined OID prefixes.

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 0% with 110 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (8cb301f) to head (b8e74eb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/database/ese/ntds/schema.py 0.00% 73 Missing ⚠️
dissect/database/ese/ntds/util.py 0.00% 16 Missing ⚠️
dissect/database/ese/ntds/database.py 0.00% 11 Missing ⚠️
dissect/database/ese/ntds/objects/object.py 0.00% 6 Missing ⚠️
dissect/database/ese/ntds/query.py 0.00% 3 Missing ⚠️
dissect/database/ese/index.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #32   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        150     150           
  Lines       4067    4123   +56     
=====================================
- Misses      4067    4123   +56     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 17, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing improve-oid (b8e74eb) with main (8cb301f)

Open in CodSpeed

@william-billaud
Copy link
Contributor

I have tested and can confirm OID no longer cause crash on my old 2012 sample.
Thanks !

@Schamper Schamper merged commit adb327d into main Feb 19, 2026
21 checks passed
@Schamper Schamper deleted the improve-oid branch February 19, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing INDEX_00000000 in NTDS Missing OID_PREFIX will cause crash when opening NTDS database

3 participants