Conversation
| DEFAULT_HMAC_ALGO = None | ||
|
|
||
|
|
||
| class SQLCipherPage: |
There was a problem hiding this comment.
This class is now largely unnecessary and can be replaced by either inlining it in _read_page or splitting it up in one or two functions.
There was a problem hiding this comment.
What do you propose? Some form of a class structure per page could still be useful for future debugging purposes. I agree that the current form of the class is overkill.
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 146 150 +4
Lines 3908 4067 +159
======================================
- Misses 3908 4067 +159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| # Initialize the decrypted SQLite3 stream as a file-like object and see if that works. | ||
| try: | ||
| super().__init__(self.stream(), wal=None, checkpoint=None) |
There was a problem hiding this comment.
Maybe not necessarily for this PR, but does SQLCipher support WAL? If so, is it deliberately not supported yet?
There was a problem hiding this comment.
Yes, SQLCipher supports WAL encryption. This hasn't been implemented yet as the WAL PR did not exist yet when this was originally written. Created an issue for that: #31.
2 participants
This PR implements transparent decryption support for SQLCipher community edition versions 1 up to 4. Fixes #17.