Skip to content

Fix VBK exception types #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Schamper merged 1 commit into from
Apr 4, 2025
Merged

Fix VBK exception types #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions dissect/archive/vbk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from dissect.util.xmemoryview import xmemoryview

from dissect.archive.c_vbk import PAGE_SIZE, c_vbk
from dissect.archive.exceptions import Error
from dissect.archive.exceptions import Error, FileNotFoundError, IsADirectoryError, NotADirectoryError

if TYPE_CHECKING:
from collections.abc import Iterator
Expand All @@ -26,14 +26,6 @@
pass


class NotAFileError(VBKError):
pass


class NotADirectoryError(VBKError):
pass


class VBK:
"""Veeam Backup (VBK) file implementation.

Expand Down Expand Up @@ -366,7 +358,7 @@

def open(self) -> BinaryIO:
"""Open the file for reading."""
raise NotAFileError(f"{self!r} is not a file")
raise IsADirectoryError(f"{self!r} is not a file")

Check warning on line 361 in dissect/archive/vbk.py

View check run for this annotation

Codecov / codecov/patch

dissect/archive/vbk.py#L361 

Added line #L361 was not covered by tests


class RootDirectory(DirItem):
Expand Down