Skip to content

Fix Child Acquisition #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Schamper merged 4 commits into from
Jan 16, 2026
Merged

Fix Child Acquisition #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fad5169
Add variable to loop over tuple
qmadev Jan 16, 2026
806b8d3
Fix unit tests
qmadev Jan 16, 2026
3e6a1f2
Add comment
qmadev Jan 16, 2026
37806a1
Fix linter
qmadev Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion acquire/acquire.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2547,7 +2547,7 @@ def acquire_children_and_targets(target: Target, args: argparse.Namespace) -> li
raise

if args.children:
for child in target.list_children():
for _, child in target.list_children():
counter += 1
acquire_gui.shard = int((progress_limit / total_targets) * counter)
try:
Expand Down
6 changes: 4 additions & 2 deletions tests/test_gui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
from collections.abc import Iterator

from dissect.target import Target
from dissect.target.helpers.record import ChildTargetRecord


@pytest.mark.parametrize(
Expand All @@ -34,8 +35,9 @@
def test_gui(
mock_target: Target, gui: GUI, num_children: int, skip_parent: bool, auto_upload: bool, expected_shards: list[int]
) -> None:
def list_children() -> Iterator[Target]:
yield from [mock_target] * num_children
def list_children() -> Iterator[tuple[str, ChildTargetRecord]]:
# We do not use the index so just set it to zero.
yield from [("0", mock_target)] * num_children

mock_target.list_children = list_children

Expand Down
Loading