Skip to content

Support message item retrieval for damage from synthetic strikes #19087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
CarlosFdez wants to merge 73 commits into
base: v13-dev
Choose a base branch
from
Draft

Support message item retrieval for damage from synthetic strikes #19087

CarlosFdez wants to merge 73 commits into from

Conversation

@CarlosFdez
Copy link
Collaborator

@CarlosFdez CarlosFdez commented May 13, 2025 •
edited
Loading

Mostly an API bug fix right now, this allows message.item to resolve for unarmed attack damage (currently it is only supported for real items). There are also type fixes.

Should we rename ChatMessagePF2e's _strike getter to just strike? It needs to be public, and I doubt strike retrieval will change soon.

stwlam and others added 30 commits May 9, 2025 03:03
@stwlam
Update system for compatibility with FVTT Dev 2
84cea50
@stwlam
Update system for compatibility with FVTT Testing 5
d50aff3
@In3luki @stwlam
Fill out v13 InteractionLayer and PlaceablesLayer types (foundryv…
f8a96f5 
…tt#18867)
@In3luki @stwlam
Fill out more v13 ApplicationV2 types (foundryvtt#18865)
89eef9c
@stwlam
Fill in more sidebar directory types, fix setting return types (found…
95e3fd2 
…ryvtt#18875)
@stwlam
Fix some rendering issues with chat log and damage-roll tooltips (fou…
eed9104 
…ndryvtt#18882)
@CarlosFdez @stwlam
Remove colors and functions intended to be removed for V13 (foundryvt…
db29bea 
…t#18881)
@CarlosFdez @stwlam
Adjust effects panel height to handle notifications area
30151ef
@CarlosFdez @stwlam
Update Effects Panel to AppV2 and fix inline rolls styling (foundryvt…
7edcae9 
…t#18886)
@In3luki @stwlam
Fill out v13 ControlsLayer and TokenLayer types (foundryvtt#18876)
e30a1eb
@CarlosFdez @stwlam
Fix persistent damage recovery button width
acbd325
@CarlosFdez @stwlam
Fix minor styling issues for v13 (foundryvtt#18897)
b3dda05
@stwlam
Continue updating types and system applications (foundryvtt#18898)
e28fa37
@CarlosFdez @stwlam
Update party folders for V13 (foundryvtt#18900)
5fbe569
@In3luki @stwlam
Fill out remaining PlaceablesLayer types (foundryvtt#18899)
8f80ae1
@In3luki @stwlam
Update CompendiumBrowser for v13 (foundryvtt#18920)
d8ed676
@In3luki @stwlam
Fix toggling of modifiers in DamageModifierDialog and `CheckModifie…
cbce085 
…rsDialog` (foundryvtt#18919)
@stwlam
Update EncounterTracker for V13, continue updating types (foundryvt…
8179bf1 
…t#18926)
@In3luki @stwlam
Fix some reported v13 issues (foundryvtt#18917)
689bd02
@stwlam
Fix parties part spreading to other document directories (foundryvtt#…
4d750f4 
…18931)
@In3luki @stwlam
Remove TinyMCE dependency and add stubbed TinyMCE types (foundryv…
5005ba4 
…tt#18927)
@In3luki @stwlam
Fix CompendiumDirectoryPF2e drag selector (foundryvtt#18936)
608f809
@stwlam
Update rest of CompendiumDirectoryPF2e for V13 (foundryvtt#18937)
f925ceb
@stwlam
Add system banners, bump version
7e1d5ab
@In3luki @stwlam
Restore erroneously removed buttons property in xp macro dialog (fo…
cab3f5b 
…undryvtt#18940)
@CarlosFdez @stwlam
Fix glow effect and label of aura effects (foundryvtt#18948)
c441de8
@stwlam
Restore functionality of system TokenConfig subclass (foundryvtt#18949
0056f04 
)
@stwlam
Fix display in chat of healing-only rolls (foundryvtt#18950)
dfb3dec
@stwlam
Fix display of @Template link icons (foundryvtt#18951)
a6df9ec
@stwlam
Remove property1 and bonusDamage fields from WeaponSystemData (f…
9f6da40 
…oundryvtt#18952)
In3luki and others added 16 commits May 9, 2025 03:03
@In3luki @stwlam
Fix showing spell template clear button (foundryvtt#19036)
06439ae
@CarlosFdez @stwlam
Fix data model issues in affliction (foundryvtt#19040)
93674c1
@stwlam
Refine mixed-in client document types (foundryvtt#19042)
719267f
@stwlam
Fix aura checks when tokens move longer distances (foundryvtt#19043)
2ea1b79
@stwlam
Update NPM dependencies, bump version (foundryvtt#19044)
9f87f9f
@In3luki
Fix TemplateLayerPF2e#getSnappedPoint (foundryvtt#19046)
b1089ac
@CarlosFdez
Convert EffectSystemData and ConditionSystemData to DataModel (foundr…
32e7f43 
…yvtt#19041)
@stwlam
Resize tokens ahead of direct actor size change (foundryvtt#19055)
b9e1d11
@In3luki
Improve MeasuredTemplate preview rotation UX for cones and lines (f…
3129fbf 
…oundryvtt#19045)
@CarlosFdez
Update persistent damage editor to app v2 (foundryvtt#19054)
a14caa5
@stwlam
Continue updating items, fix type-only imports (foundryvtt#19069)
09348d4
@In3luki
Prevent normal drag operations when a MeasuredTemplate preview is a…
9b7e7ac 
…ctive (foundryvtt#19072)
@FolkvangrForgent
Move aura grid type check to scene getter (foundryvtt#19076)
3070a7b
@stwlam
Fill in settings menu class type definitions (foundryvtt#19082)
d4b6f07
@CarlosFdez
Convert ClassSystemData to TypeDataModel (foundryvtt#19065)
4b01e9c
@stwlam
Convert WorldClockSettings to ApplicationV2 (foundryvtt#19083)
14aecc2
@CarlosFdez CarlosFdez changed the title Fix message item retrieval for damage from synthetic items Support message item retrieval for damage from synthetic items May 13, 2025
@CarlosFdez CarlosFdez changed the title Support message item retrieval for damage from synthetic items Support message item retrieval for damage from synthetic strikes May 13, 2025
@stwlam
Copy link
Collaborator

stwlam commented May 13, 2025

Public is fine, but it needs to be understood as non-contractual. Maybe mark it @internal? Or just warn Idle.

@CarlosFdez
Copy link
Collaborator Author

CarlosFdez commented May 13, 2025

I'll keep it as _strike then, since that can be used to understand it as non-contractual, but I added @internal. There's nothing really wrong persay with the strike getter, but more that strikes haven't jumped to the statistic api yet.

@CarlosFdez CarlosFdez force-pushed the strike-retrieval-damage branch from 769bc34 to 92b7cdc Compare May 13, 2025 06:14
@CarlosFdez CarlosFdez marked this pull request as draft May 13, 2025 19:54
@CarlosFdez CarlosFdez force-pushed the v13-dev branch 2 times, most recently from 33779b2 to 6c3556e Compare May 21, 2025 00:44
@CarlosFdez CarlosFdez force-pushed the v13-dev branch 2 times, most recently from 69ee8a9 to 504abfc Compare May 27, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr: bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CarlosFdez @stwlam @In3luki @Cuingamehtar @FolkvangrForgent