Add birthAugur item type for extensible birth augur automation#686
Open
Add birthAugur item type for extensible birth augur automation#686
Conversation
Create module/birth-augurs.mjs with all 30 DCC birth augurs, their effect types, and a matchAugurFromText() helper for migration/parsing. Add birthAugurIndex field to base-actor.mjs with auto-migration from existing birthAugur text. Add birthAugurMode config to player-data.mjs. Refs: #684 #470 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…d tests - Use birthAugurEffect instead of birthAugurMod in template conditional to avoid Handlebars treating 0 as falsy (hid modifier for luck 10-11) - Clear _computedBirthAugurEffect and _computedBirthAugurMod when no augur is selected to prevent stale values - Add tests for armorClass and speed augur effects - Remove unused i18n keys (BirthAugurCustom, BirthAugurIndex) - Fix design doc file name reference Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Translate 37 new birth augur i18n keys into Chinese, German, Spanish, French, Italian, and Polish. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Register new birthAugur item type with data model (effect field), config entries (item type, default image, effect dropdown labels), system.json document type, item-piles filter, compendium link, and bump migration version to 0.67. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cyface
changed the title
- Move _birthAugurItem cache before compute methods in prepareDerivedData to fix item-based augur bonuses not applying - Add .catch() to fire-and-forget deleteEmbeddedDocuments in _onCreateDescendantDocuments - Add warning log for out-of-range augurIndex in migration - Fix DCC.Delete → DCC.ItemDelete in template tooltip - Simplify _getBirthAugurBonusFor to use cached _birthAugurItem - Simplify item-based tests to set _birthAugurItem directly Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
birthAuguritem type: Extensible item witheffectfield for automation (replaces hard-coded index-only approach)_getBirthAugurBonusFor()andprepareDerivedData()check birthAugur items first, falling back to legacybirthAugurIndexfor un-migrated characters_onCreateDescendantDocumentsbirthAugurIndexmigrateBirthAugurToItem()creates birthAugur items for Player actors with legacybirthAugurIndexCompanion PR
Test plan
npm test— 553 tests passnpm run format— lint cleannpm run compare-lang— no missing keys🤖 Generated with Claude Code