Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Merges all recent bugfixes and features from main while preserving v14 compatibility changes: - Keep v14 Active Effects using CONFIG.DCC.effectChangeTypes and change.type - Include deedDieRoll cleanup fix from main - Preserve v14 DataModel field handling in active-effect.js 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Resolved conflict in module/item-sheet.js (kept comment from main) - Added missing DCC.EffectChangeTypeDiceChain translation to all language files 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Resolved conflict in lang/cn.json - kept v14-specific key (DCC.EffectChangeTypeDiceChain) while preserving Chinese translations from main. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Brings in crit/fumble navigation features and backward compatibility: - TableResult class for navigable crit/fumble results - critResult/fumbleResult properties with legacy aliases - critRollTotal/fumbleRollTotal for roll values Resolved conflicts: - Removed unused critRollIndex/fumbleRollIndex in favor of new approach 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Merged changes from main including: - Fix for Active Effects string-to-number conversion (#663, #664) - Comprehensive active effects tests (#665) - Backstab fallback value fix - ACTIVE_EFFECT_MODES and setProperty mock additions All 480 tests pass, all checks pass. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Migrate ActiveEffect change.mode (numeric) to change.type (string) for v14 - Auto-detect dice expressions in add/subtract effects for dice chain logic - Convert custom diceChain type to standard add/subtract in migrations - Fix double effect application by checking phase parameter - Update effect pack files to use standard add/subtract types - Update partial-effects template to use string type comparisons - Add phase check to applyActiveEffects to prevent double application in v14 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Update status to Developer 1 (Build 354) - Add Scene Levels documentation - Add TinyMCE full removal info - Add new DataModel performance improvements - Add Placeables Palette technical preview - Add new breaking changes (TextureData, Macro#author, Wall properties) - Add new utility function renames - Update Active Effects with Developer 1 fixes - Update checklist with new items - Add merge-v14 skill for merging main into feature/v14 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
V14 deprecates numeric ACTIVE_EFFECT_MODES in favor of string-based ACTIVE_EFFECT_CHANGE_TYPES. Add the new constant to test mocks. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.