Skip to content

remove unnecessary use of json body parser #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marwa7med wants to merge 2 commits into
base: master
Choose a base branch
from
Open

remove unnecessary use of json body parser #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dde125
remove unnecessary use of json body parser
marwa7med Feb 21, 2018
0ad9f37
// import body-parser module
marwa7med Feb 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions 10-post-form/src/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ const app = express();

app.use(favicon(path.join(__dirname, '..', 'public', 'favicon.ico')));

// parse incoming json

// parse urlencoded bodies

app.use(express.static(path.join(__dirname, '..', 'public')));
Expand Down
2 changes: 0 additions & 2 deletions solution/10-post-form/src/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ const app = express();

app.use(favicon(path.join(__dirname, '..', 'public', 'favicon.ico')));

// parse incoming json
app.use(bodyParser.json());
// parse urlencoded bodies
app.use(bodyParser.urlencoded({ extended: false }));
Copy link
Member

@eliasmalik eliasmalik Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you actually run the code after your changes?

Running this file will result in a ReferenceError because you've removed line 5, where bodyParser is defined, yet still refer to it on line 14.


Expand Down