Skip to content

Use "sass:string" for unquote function #15520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
p8 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Use "sass:string" for unquote function #15520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions scss/util/_breakpoint.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
/// @group breakpoints
////

@use "sass:string";

/// Patch to fix issue #12080
$-zf-size: null;

Expand Down Expand Up @@ -404,35 +406,35 @@ $small-only: '';

@if map-has-key($breakpoints, small) {
$small-up: screen;
$small-only: unquote('screen and #{breakpoint(small only)}');
$small-only: string.unquote('screen and #{breakpoint(small only)}');
}

$medium-up: '';
$medium-only: '';

@if map-has-key($breakpoints, medium) {
$medium-up: unquote('screen and #{breakpoint(medium)}');
$medium-only: unquote('screen and #{breakpoint(medium only)}');
$medium-up: string.unquote('screen and #{breakpoint(medium)}');
$medium-only: string.unquote('screen and #{breakpoint(medium only)}');
}

$large-up: '';
$large-only: '';

@if map-has-key($breakpoints, large) {
$large-up: unquote('screen and #{breakpoint(large)}');
$large-only: unquote('screen and #{breakpoint(large only)}');
$large-up: string.unquote('screen and #{breakpoint(large)}');
$large-only: string.unquote('screen and #{breakpoint(large only)}');
}

$xlarge-up: '';
$xlarge-only: '';

@if map-has-key($breakpoints, xlarge) {
$xlarge-up: unquote('screen and #{breakpoint(xlarge)}');
$xlarge-only: unquote('screen and #{breakpoint(xlarge only)}');
$xlarge-up: string.unquote('screen and #{breakpoint(xlarge)}');
$xlarge-only: string.unquote('screen and #{breakpoint(xlarge only)}');
}

$xxlarge-up: '';

@if map-has-key($breakpoints, xxlarge) {
$xxlarge-up: unquote('screen and #{breakpoint(xxlarge)}');
$xxlarge-up: string.unquote('screen and #{breakpoint(xxlarge)}');
}
4 changes: 3 additions & 1 deletion scss/util/_selector.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
/// @group functions
////

@use "sass:string";

/// Generates a selector with every text input type. You can also filter the list to only output a subset of those selectors.
///
/// @param {List|Keyword} $types [()] - A list of text input types to use. Leave blank to use all of them.
Expand All @@ -20,7 +22,7 @@
}

@each $type in $types {
$return: append($return, unquote('[type=\'#{$type}\']#{$modifier}'), comma);
$return: append($return, string.unquote('[type=\'#{$type}\']#{$modifier}'), comma);
}

@return $return;
Expand Down
6 changes: 4 additions & 2 deletions scss/xy-grid/_gutters.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
/// @group xy-grid
////

@use "sass:string";

/// Create gutters for a cell/container.
///
/// @param {Number|Map} $gutters [$grid-margin-gutters] - Map or single value for gutters.
Expand All @@ -30,7 +32,7 @@

// Loop through each gutter position
@each $value in $gutter-position {
#{$gutter-type}-#{$value}: unquote("#{$operator}#{$gutter}");
#{$gutter-type}-#{$value}: string.unquote("#{$operator}#{$gutter}");
}
}
}
Expand All @@ -39,7 +41,7 @@

// Loop through each gutter position
@each $value in $gutter-position {
#{$gutter-type}-#{$value}: unquote("#{$operator}#{$gutter}");
#{$gutter-type}-#{$value}: string.unquote("#{$operator}#{$gutter}");
}
}
}