Display ⌘ in the search UI on Apple devices
#198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for adding this. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently support the
metaKeyfor jumping to the search box, but the user interface still displays Ctrl because this is hard-coded. This update will change it to display the ⌘ key on my macOS machine.I also added the
whitespace-nowrapclass to prevent content from wrapping onto multiple lines on narrower screens. Additionally, I increased the opacity from 50% to 80%, as the previous opacity violated the minimum contrast ratio required for accessibility (80% meets this standard). Please let me know if you'd like me to split this into its own PR.