perf(agents): avoid per-file recomputation and clean up temp files#126
Open
DhruvrajSinhZala24 wants to merge 2 commits intofossology:masterfrom
Open
perf(agents): avoid per-file recomputation and clean up temp files#126DhruvrajSinhZala24 wants to merge 2 commits intofossology:masterfrom
DhruvrajSinhZala24 wants to merge 2 commits intofossology:masterfrom
Conversation
- Transitioned TF-IDF, Word Frequency, Damerau-Levenshtein, and N-gram agents to a precomputed vector search model. - Hoisted heavy initialization (fitting, tokenization) to __init__ to improve scan performance from O(N*F) to O(F). - Implemented cleanup() mechanism in AtarashiAgent to resolve temporary file leaks in /tmp. - Fixed a shared-state mutation bug in NgramAgent that corrupted datasets across multiple scans. - Verified semantic parity with baseline implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves repeated recomputation in the Atarashi similarity agents and fixes temporary comment-file leaks noted in Issue #124. Expensive license-corpus preprocessing is performed once per agent instance, and scan paths now consistently clean up temp files.
Key Changes
Performance (precomputation / hoisted work)
Resource management (temp-file cleanup)
AtarashiAgent.cleanup()and ensures it runs viafinallyin all agents so temp files created byCommentPreprocessor.extract()are removed even on exact matches / early returns / exceptions.Bug fixes
Benchmarks (local, illustrative)
20
.pyfiles fromatarashi/(sorted), 774-license corpus (processedLicenses.csv), single agent instance:origin/masterVerification
.github/workflows/build-test.yml).origin/masteron representative files; top matches unchanged for TF-IDF (Cosine/Score), WordFrequency, DLD, and N-gram.Fixes #124