fix(commentPreprocessor, licenseDownloader): normalize keyword matching, SPDX URL handling, missing comma#123
Open
divyamagrawal06 wants to merge 2 commits intofossology:masterfrom
Open
Conversation
…eyword matching Signed-off-by: divyamagrawal06 <ludicrouslytrue@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small bug fixes in comment extraction and SPDX download normalization.
Changes
Updated keyword normalization in commentPreprocessor.py by cleaning list formatting (added a missing comma) and added "merchantability" keyword support ("merchantibility" exists, but "merchantability" is the common spelling).
Normalized seeAlso handling in licenseDownloader.py so that the url is stored consistently as a string.
One-row DataFrame creation per license/exception entry using [licenseDict].
Made SPDX filename generation Windows-safe by sanitizing the releaseDate before building CSV filename in licenseDownloader.py.
How to test
Create a new test file ex:
dummy_license_file.txtpoetry run atarashi -a DLD .\dummy_license_file.txtValidation:
Output from tests:
