fix: add try-except block to comment extraction to prevent TF-IDF crash (#114)#121
Open
DhruvrajSinhZala24 wants to merge 1 commit intofossology:masterfrom
Open
fix: add try-except block to comment extraction to prevent TF-IDF crash (#114)#121DhruvrajSinhZala24 wants to merge 1 commit intofossology:masterfrom
DhruvrajSinhZala24 wants to merge 1 commit intofossology:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114
Problem
When running the Atarashi TF-IDF agent on real-world source trees (e.g., BusyBox), the scan occasionally crashes due to unhandled exceptions originating from the
nirjascomment extractor. This results in the entire scanner terminating prematurely, which impacts the reliability of FOSSology scans.Reproduction Steps
atarashi -a tfidf -s CosineSim path/to/file.c).nirjasinstead of completing the scan.Root Cause
The
CommentPreprocessor.extract()method previously assumed that comment extraction would always succeed for supported file extensions and only used simpleif-elselogic. However,nirjas.extract()can raise exceptions when encountering files with unexpected encodings, drastically malformed comment blocks (e.g., unclosed comments), or rare syntax patterns. These unhandled exceptions bubble up and halt the entireatarashiagent.Fix Implemented
I have added a
try...exceptblock around the comment extraction phase inatarashi/libs/commentPreprocessor.py.nirjas.extract()fails, the exception is caught.Testing Performed
nirjasexception correctly triggers the fallback path, extracting all text from the raw file as expected.