Skip to content

fix(messages): fix typos and misleading error messages in audit, dash…#210

Open
aaryan359 wants to merge 1 commit intofossology:mainfrom
aaryan359:fix/various-error-message-typos
Open

fix(messages): fix typos and misleading error messages in audit, dash…#210
aaryan359 wants to merge 1 commit intofossology:mainfrom
aaryan359:fix/various-error-message-typos

Conversation

@aaryan359
Copy link
Copy Markdown
Contributor

Changes

  • Fix typo in dashboard.go: "error fetching risk liicense frequencies""error fetching risk license frequencies" (double i)
  • Fix misleading error messages in audit.go — UUID parse errors in GetAudit, GetChangeLogs, and GetChangeLogbyId were copy-pasted from the license handlers and incorrectly said "no license with id '%s' exists"; now correctly say "no audit with id '%s' exists" or "no changelog with id '%s' exists"
  • Fix misleading error messages in obligations.go — 8 occurrences of "Failed to update license" in obligation update/import paths were copy-pasted from the license handler; now correctly say "Failed to update obligation"

Submitter Checklist

  • Includes tests (if there is a feature changed/added)
  • Includes docs ( if changes are user facing)
  • I have tested my changes locally.

References

Location Was Now
pkg/api/dashboard.go:101 "error fetching risk liicense frequencies" "error fetching risk license frequencies"
pkg/api/audit.go:99 — GetAudit "no license with id '%s' exists" "no audit with id '%s' exists"
pkg/api/audit.go:157 — GetChangeLogs "no license with id '%s' exists" "no audit with id '%s' exists"
pkg/api/audit.go:224 — GetChangeLogbyId (audit ID) "no license with id '%s' exists" "no audit with id '%s' exists"
pkg/api/audit.go:237 — GetChangeLogbyId (changelog ID) "no license with id '%s' exists" "no changelog with id '%s' exists"
pkg/api/obligations.go (8 occurrences) "Failed to update license" "Failed to update obligation"

…board and obligations

Signed-off-by: aaryan359 <aaryanmeena96@gmail.com>
@aaryan359
Copy link
Copy Markdown
Contributor Author

@deo002, Please look at this. Does this look good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant