refactor(laas): convert schema generator logging to structured zap logger#176
Closed
Joshna907 wants to merge 1 commit intofossology:mainfrom
Closed
refactor(laas): convert schema generator logging to structured zap logger#176Joshna907 wants to merge 1 commit intofossology:mainfrom
Joshna907 wants to merge 1 commit intofossology:mainfrom
Conversation
Joshna907
force-pushed
the
gen-external-ref-zap-logging
branch
2 times, most recently
from
3c66177 to
a5284fa
Compare
deo002
requested changes
Jan 12, 2026
cmd/laas/gen_external_ref_schema.go
Outdated
| } | ||
| if err != nil { | ||
| log.Fatalf("Failed to instantiate json schema for external ref in license: %v", err) | ||
| logger.LogError("Failed to instantiate json schema for external ref in license", zap.Error(err)) |
Collaborator
There was a problem hiding this comment.
LogFatal would be better here as the script should not run any further if there is an error in parsing a field
Joshna907
force-pushed
the
gen-external-ref-zap-logging
branch
from
d410855 to
9caf1e4
Compare
ChayanDass
approved these changes
Jan 16, 2026
Comment on lines
-44
to
45
| log.Fatalf("Failed to instantiate json schema for external ref in license: %v", err) | ||
| logger.LogFatal("Failed to read external_ref_fields.yaml", zap.Error(err)) | ||
| } |
Contributor
There was a problem hiding this comment.
Keep the fatal messages as they are!
Joshna907
force-pushed
the
gen-external-ref-zap-logging
branch
8 times, most recently
from
2e1d78d to
d0ed12c
Compare
Contributor
Author
@deo002 , @Kaushl2208 Can we merge this pull request? it's done, Thank you |
Joshna907
force-pushed
the
gen-external-ref-zap-logging
branch
from
d0ed12c to
ae015f6
Compare
Member
|
Changes included in #193 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change refactors logging in cmd/laas/gen_external_ref_schema.go by replacing standard log calls with structured Zap logging for error handling and fatal exits.