feat(externalref): Add external ref to obligations#153
Closed
deo002 wants to merge 1 commit intofossology:mainfrom
Closed
feat(externalref): Add external ref to obligations#153deo002 wants to merge 1 commit intofossology:mainfrom
deo002 wants to merge 1 commit intofossology:mainfrom
Conversation
deo002
requested review from
GMishx and
Kaushl2208
and removed request for
Kaushl2208
Kaushl2208
requested changes
Aug 18, 2025
Member
Kaushl2208
left a comment
Kaushl2208
left a comment
There was a problem hiding this comment.
Just a small change recommendation. Will test it
| "comment": { | ||
| "type": "string" | ||
| }, | ||
| "externalRef": { |
Member
There was a problem hiding this comment.
Can we bring more consistency in naming? I see there is externalRef in json and external_ref in Go Structs?
Collaborator
Author
There was a problem hiding this comment.
Yes Kaushl, This is the schema for Go struct in swagger. In json, it's external_ref.
Member
|
@deo002 , While creating obligations getting this: |
deo002
force-pushed
the
feat/obligationExternalRef
branch
2 times, most recently
from
9e01c84 to
2fb3624
Compare
Signed-off-by: deo002 <oberoidearsh@gmail.com>
deo002
force-pushed
the
feat/obligationExternalRef
branch
from
2fb3624 to
266c938
Compare
Collaborator
Author
|
Closing in favor of #198 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Submitter Checklist