fix(obligations_creation): Ensure license BeforeCreate hook runs only during creation (#121)

[ChayanDass]

Problem

When creating an Obligation with shortnames, the BeforeCreate hook is triggered due to the licensedb being associated with shortames. However, this leads to a username not found in context error

Changes

• Refactored the BeforeCreate hook to run only during creation by adding check.
• Improved efficiency by preventing redundant operations during updates. (it will ensure beforecreate hook only run on creation not on update )
• Fixes obligations creating error with shortnames #121

Submitter Checklist

• Includes tests (if there is a feature changed/added)
• Includes docs (if changes are user-facing)
• I have tested my changes locally.

References

• no problem on creation of obligation
  

• on problem on creation of license

[ChayanDass]

@deo002 , can you please review this pr ?

[deo002]

Ideally, on obligation creation, the BeforeCreate hook(for Licenses) shouldn't run as the Licenses to be associated already exist and aren't new. A good approach would be to ensure BeforeCreate doesn't run in this case instead of adding a check in it. What do you suggest?

However, on creating an obligation, GORM treats the licenses in o.Licenses array as new records and creates them if they do not already exist instead of treating them as existing records. This triggers the BeforeCreate hook for licenses.

Can we first create the obligation and then associate existing licenses to it via associations? This way, BeforeCreate hook wont run.

[deo002]

I am really sorry for not checking this PR until now Chayan. Could you rebase it with the current main or open a new PR, which ever one is easier? Thanks!

[ChayanDass]

Closing in favour of #149