Scam Detector - Removal of Contract Similarity base bot#661
Open
Scam Detector - Removal of Contract Similarity base bot#661
Conversation
Vxatz
reviewed
Jun 25, 2024
Contributor
There was a problem hiding this comment.
- Please update the
release.md(where we keep track of the changes) base_bot_additions.mdcontains some instructions regarding contract similarity bots, but I think we can leave it there in case we want to add one back in the futureforta_explorer_mock.pyhas some logic which is not needed anymoreif entity == '' and label_query == 'similar-contract':...
The changes made LGTM, my comments are only about things that could additionally be removed, although of lesser importance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.