Add Base - Level Reporting - Requirement 4#123
Merged
beichen1024 merged 8 commits intomainfrom Oct 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a "base" column to various aggregation tables and reports, which contains the sum of mapped lengths for alignment data. The change enhances the reporting functionality by providing both count and length-based metrics.
- Adds base column calculation using pre-aggregated alignment data
- Updates R Markdown report to display the new base counts in tables
- Modifies flip-flop aggregation to include length summation alongside counts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/aggregate_tables.py | Adds base column calculation by merging alignment length data and updating aggregation functions |
| src/report.Rmd | Updates table headers and column selections to include the new "Base Counts" column |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mcrocker-bioborg
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: https://formbio.atlassian.net/browse/PRO-959
test run: https://app.formbio.com/organizations/formbio/projects/utsw_benchvalidation/workflow-runs/c1124e3b-d501-44ab-b185-5fdc0c4c92f9/?panel=&previousPageParams=%7B%22orgId%22%3A%22formbio%22%2C%22pid%22%3A%22utsw_benchvalidation%22%2C%22panel%22%3A%22%22%2C%22status%22%3A%22%22%2C%22users%22%3A%22%22%7D&selectedFile=&supportFile=&tab=Results
tsv column updated

report stays unchanged