Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the BigDecimal library, focusing on improving the precision and performance of mathematical operations. The changes involve modifying benchmarks, adding new functions, and optimizing existing ones.
Benchmark Updates:
benches/bigdecimal/bench_bigdecimal_exp.mojoto use more realistic values for the exponential function tests. [1] [2] [3] [4]benches/bigdecimal/bench_bigdecimal_sqrt.mojoto improve accuracy.Function Enhancements:
true_divide_fastfunction insrc/decimojo/bigdecimal/arithmetics.mojofor faster division with a specified minimum precision.true_divide_fastfunction into theBigDecimalstruct and thesqrtfunction to enhance performance. [1] [2]Code Optimization:
exp) insrc/decimojo/bigdecimal/exponential.mojoby using thetrue_divide_fastfunction and optimizing the range reduction process. [1] [2]Documentation and Comments:
true_dividefunction to specify the precision parameter.sqrtandexpfunctions. [1] [2]These changes collectively aim to make the BigDecimal library more efficient and accurate for mathematical computations.