Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and new features to the
decimojolibrary, focusing on arithmetic operations, comparison functions, and benchmarking. The most important changes are the addition of the Toom-Cook 3-way multiplication algorithm, new power and comparison methods for theBigUIntstructure, and updates to the benchmarking script.Arithmetic Enhancements:
src/decimojo/biguint/arithmetics.mojo: Added themultiply_toom_cook_3function, implementing the Toom-Cook 3-way multiplication algorithm for efficient large number multiplication.Power Methods:
src/decimojo/biguint/biguint.mojo: Introduced__pow__andpowermethods to theBigUIntstructure, allowing exponentiation with bothIntandBigUInttypes. [1] [2]Comparison Functions:
src/decimojo/biguint/comparison.mojo: Added new comparison functions (greater,greater_equal,less,less_equal,equal,not_equal) to facilitate comparisons betweenBigUIntinstances.Benchmarking:
benches/biguint/bench.mojo: Updated the benchmarking script to include thebench_multiplyfunction for testing multiplication performance.Documentation:
README.md: Corrected a typo in the section heading "Nomenclature".