Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
README.mdfile and updates to thebench_biguint_truncate_divide.mojoandarithmetics.mojofiles to improve documentation, update benchmarks, and refine arithmetic operations.Code improvement:
divideoperation ofBigUInt, making it correct for cases against Python's Int and making it faster than Python's Int for numbers up to 1000 digits. For numbers with more than 1000 digits, the limit performance will be around x0.25 compared to Python.Codebase Simplification:
truncate_dividefunction tofloor_divideinarithmetics.mojoto better reflect its operation.arithmetics.mojofor better readability.arithmetics.mojo.Documentation Updates:
README.md.BigIntandBigDecimalfor clarity and precision inREADME.md.Benchmark Enhancements:
bench_biguint_truncate_divide.mojo.truncate_dividewith//operator inbench_biguint_truncate_divide.mojo.