Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request involves renaming the
floor_dividefunction and all related references totruncate_divideacross multiple files. The changes ensure consistency in the naming convention and update the logic accordingly.Renaming and Updating Functions:
benches/decimal/bench.mojo: Renamedbench_floor_dividetobench_truncate_dividein the import statements and function calls.benches/decimal/bench_truncate_divide.mojo: Renamed frombench_floor_divide.mojoand updated all instances ofrun_benchmark_floor_dividetorun_benchmark_truncate_divide.src/decimojo/__init__.mojo: Updated import statement fromfloor_dividetotruncate_divide.src/decimojo/decimal/arithmetics.mojo: Renamedfloor_dividefunction totruncate_divideand updated the corresponding logic in themodulofunction.Updating
DecimalStruct:src/decimojo/decimal/decimal.mojo: Updated all instances offloor_dividetotruncate_dividein the__floordiv__,__mod__,__rfloordiv__,__rmod__,__ifloordiv__, and__imod__methods. Added docstrings to reflect the changes.