Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
decimojopackage, specifically focusing on improving theBigIntarithmetic operations and parsing of numeric strings. The most important changes include the introduction of a new method to check if aBigIntis zero, replacing string-based coefficients with list-based coefficients, and adding new augmented arithmetic assignment methods.Improvements to
BigIntarithmetic operations:src/decimojo/bigint/arithmetics.mojo: Introduced theis_zeromethod to simplify zero-checks in theaddfunction.src/decimojo/bigint/arithmetics.mojo: Corrected the return statements in theadd,subtract, andnegativefunctions to properly return the result.src/decimojo/bigint/arithmetics.mojo: Simplified theabsolutefunction by directly returning the negated value if the sign is set.Parsing and coefficient handling:
src/decimojo/str.mojo: Changed theparse_string_of_numberfunction to return a list ofUInt8coefficients instead of a string, improving efficiency and clarity.src/decimojo/bigint/bigint.mojo: Updated thefrom_stringmethod to use the new list-based coefficients and adjusted the logic to handle these coefficients.New augmented arithmetic assignment methods:
src/decimojo/bigint/bigint.mojo: Added__iadd__and__isub__methods for in-place addition and subtraction, respectively.