Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant refactoring and improvements to the
Decimalstruct in thedecimojolibrary. The main changes involve simplifying the initialization ofDecimalobjects and adding a new method for creatingDecimalinstances fromUInt128values.Initialization Refactoring:
IntandUInt128values.New Method for
UInt128Initialization:from_uint128to initialize aDecimalfrom aUInt128value, including validation for the value and scale.Code Simplification:
from_uint128method for creatingDecimalinstances fromUInt128values.sqrtfunction to use the newfrom_uint128method.roundfunction to use the newfrom_uint128method.