Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Decimo CLI argument parsing so expressions that start with - (e.g., negative numbers / negative expressions) can be passed as the positional <EXPR> more naturally, and documents/tests the behavior.
Changes:
- Enable hyphen-prefixed values for the
exprpositional argument via ArgMojo (allow_hyphen=True) and remove the older command-level negative-number allowance. - Expand CLI integration tests to cover negative expressions, mixed option/positional ordering, and
--separator cases. - Add user-manual documentation for “Negative Expressions” and update the CLI calculator plan checklist accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/cli/main.mojo |
Allows expr positional to start with - and removes allow_negative_numbers() usage. |
tests/test_cli.sh |
Adds integration coverage for negative expressions and option/positional ordering. |
docs/user_manual_cli.md |
Documents negative-expression usage (needs clarification for option-like collisions). |
docs/plans/cli_calculator.md |
Updates planning checklist notes for the new approach (one option name inconsistency). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Decimo CLI argument parsing so expressions that start with
-(e.g., negative numbers / negative expressions) can be passed as the positional<EXPR>more naturally, and documents/tests the behavior.Changes:
exprpositional argument via ArgMojo (allow_hyphen=True) and remove the older command-level negative-number allowance.--separator cases.