Conversation
There was a problem hiding this comment.
Pull request overview
Adds a Python-compatible as_tuple() API to BigDecimal and updates docs/tests to reflect recent BigDecimal utility-method additions/removals.
Changes:
- Implement
BigDecimal.as_tuple()returning(sign, digits, exponent)aligned with Pythondecimal.Decimal.as_tuple(). - Add a new BigDecimal methods test module including coverage for
as_tuple()and other recently added helpers. - Update roadmap/README documentation to reflect completed items and version formatting.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tests/bigdecimal/test_bigdecimal_methods.mojo | New tests for utility methods; adds as_tuple() round-trip checks. |
| src/decimo/bigdecimal/bigdecimal.mojo | Implements as_tuple() and removes number_of_significant_digits(). |
| docs/plans/api_roadmap.md | Marks as_tuple() and other items as done; updates wording/status markers. |
| README.md | Adjusts version strings in the compatibility table (adds v prefix). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
forfudan
added a commit
that referenced
this pull request
Mar 23, 2026
Adds a Python-compatible `as_tuple()` API to `BigDecimal` and updates docs/tests to reflect recent BigDecimal utility-method additions/removals. **Changes:** - Implement `BigDecimal.as_tuple()` returning `(sign, digits, exponent)` aligned with Python `decimal.Decimal.as_tuple()`. - Add a new BigDecimal methods test module including coverage for `as_tuple()` and other recently added helpers. - Update roadmap/README documentation to reflect completed items and version formatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Python-compatible
as_tuple()API toBigDecimaland updates docs/tests to reflect recent BigDecimal utility-method additions/removals.Changes:
BigDecimal.as_tuple()returning(sign, digits, exponent)aligned with Pythondecimal.Decimal.as_tuple().as_tuple()and other recently added helpers.