Conversation
There was a problem hiding this comment.
Pull request overview
Updates string-formatting APIs and CLI/docs to support newer BigDecimal to_string options while aligning BigInt’s string conversion naming with the rest of the numeric types.
Changes:
- Rename BigInt’s
to_decimal_stringusage toto_string(including dunders and writer output). - Clarify CLI formatting flags as mutually exclusive (scientific vs engineering).
- Update API roadmap documentation to reflect
to_string(scientific=True)naming.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/decimo/bigint/bigint.mojo | Switches BigInt string conversion entrypoint from to_decimal_string to to_string across public outputs. |
| src/cli/main.mojo | Adds a clarifying comment about mutually exclusive formatting flags. |
| docs/plans/api_roadmap.md | Updates documentation to match the current to_string(scientific=True) parameter name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…name BigInt to_decimal_string to to_string - Add force_plain, engineering, delimiter parameters to BigDecimal.to_string() - Rename BigInt.to_decimal_string() to to_string(); keep deprecated alias - Update tests to use the new to_string() name - Clarify CLI formatting flags as mutually exclusive (scientific vs engineering) - Update API roadmap documentation to reflect to_string(scientific=True) naming
forfudan
added a commit
that referenced
this pull request
Mar 23, 2026
…igDecimal` (#172) Updates string-formatting APIs and CLI/docs to support newer BigDecimal `to_string` options while aligning BigInt’s string conversion naming with the rest of the numeric types. **Changes:** - Rename BigInt’s `to_decimal_string` usage to `to_string` (including dunders and writer output). - Clarify CLI formatting flags as mutually exclusive (scientific vs engineering). - Update API roadmap documentation to reflect `to_string(scientific=True)` naming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates string-formatting APIs and CLI/docs to support newer BigDecimal
to_stringoptions while aligning BigInt’s string conversion naming with the rest of the numeric types.Changes:
to_decimal_stringusage toto_string(including dunders and writer output).to_string(scientific=True)naming.