feat: introduce DatasetMeta dataclass to reduce parameter explosion#86
Merged
maxine-at-forecast merged 2 commits intodevelopfrom Apr 1, 2026
Conversation
…CL-4] Bundle the six shared metadata fields (name, schema_ref, description, tags, license, metadata) into a DatasetMeta dataclass. Index.insert_dataset, Index.write_samples, and all DatasetPublisher.publish* methods now accept an optional meta= keyword alongside the existing flat kwargs for backward compatibility. Explicit kwargs override meta fields. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DatasetMetadataclass bundling 6 shared metadata fields (name, schema_ref, description, tags, license, metadata) into a single parameter objectIndex.insert_dataset,Index.write_samples, and allDatasetPublisher.publish*methods now accept an optionalmeta=keyword.design/084-architectural-refactoring.md(GH QA: Architectural review — findings and recommendations #84)Files changed
src/atdata/dataset_meta.pyDatasetMetadataclass +_resolve_meta()helpersrc/atdata/__init__.pyDatasetMetasrc/atdata/index/_index.pyinsert_dataset&write_samplesacceptmeta=src/atdata/atmosphere/records.pypublish*methods acceptmeta=src/atdata/repository.py_AtmosphereBackendpassesDatasetMetathroughtests/test_dataset_meta.pyTest plan
_resolve_metamerging/override, Index integration, and error casesruff check)Closes CL-4
🤖 Generated with Claude Code