Skip to content

feat: Add Custom Sample Slicing UI#439

Merged
ford442 merged 1 commit intomainfrom
feat/custom-sample-slicing-ui-3675724099669744707
Apr 12, 2026
Merged

feat: Add Custom Sample Slicing UI#439
ford442 merged 1 commit intomainfrom
feat/custom-sample-slicing-ui-3675724099669744707

Conversation

@ford442
Copy link
Copy Markdown
Owner

@ford442 ford442 commented Apr 12, 2026

Adds a new feature to allow users to manually edit sample slicing markers (add, remove, drag) on the WaveformDisplay in SamplerPanel.tsx.


PR created automatically by Jules for task 3675724099669744707 started by @ford442

- Update `AudioEngine` to support `updateAlignment`.
- Expose `updateAlignment` in `sampleManagement.ts` and `useAudioEngine.ts`.
- Implement dragging, adding (double-click), and deleting (double-click) markers in `WaveformDisplay.tsx` using an `onAlignmentChange` callback.
- Connect `SamplerPanel.tsx` to pass the updated alignment state to the audio engine.
- Mark the task as complete in `agent_plan.md`.

Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ford442 ford442 merged commit 2036154 into main Apr 12, 2026
1 check failed
@ford442 ford442 deleted the feat/custom-sample-slicing-ui-3675724099669744707 branch April 12, 2026 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant