Skip to content

🎨 Palette: Add ARIA labels to buttons in Modals #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ford442 merged 1 commit into from
Apr 12, 2026
+8 −0
Merged

🎨 Palette: Add ARIA labels to buttons in Modals #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/components/AISongModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,6 +926,7 @@ export function AISongModal({ isOpen, onClose, onImport, onShowToast, audioEngin
<button
onClick={handleFixCommonIssues}
className="px-3 py-1 bg-red-900/50 hover:bg-red-800/50 text-red-300 text-xs rounded transition-all"
aria-label="Fix Common JSON Issues"
>
🔧 Fix Issues
</button>
Expand All @@ -935,6 +936,7 @@ export function AISongModal({ isOpen, onClose, onImport, onShowToast, audioEngin
<button
onClick={copyErrorReport}
className="px-3 py-1 bg-gray-800 hover:bg-gray-700 text-gray-400 text-xs rounded transition-all"
aria-label="Copy error details to clipboard"
>
{copiedError ? '✓ Copied!' : '📋 Copy'}
</button>
Expand Down Expand Up @@ -1044,6 +1046,7 @@ export function AISongModal({ isOpen, onClose, onImport, onShowToast, audioEngin
<button
onClick={copyTemplate}
className="mb-3 px-4 py-2 bg-emerald-600 hover:bg-emerald-500 text-white text-xs font-medium rounded transition-all flex items-center gap-2"
aria-label="Copy AI Prompt Template"
>
<span>📋</span> Copy Template
</button>
Expand Down Expand Up @@ -1258,6 +1261,7 @@ export function AISongModal({ isOpen, onClose, onImport, onShowToast, audioEngin
className="px-4 py-2 bg-emerald-600 hover:bg-emerald-500 text-white text-sm font-medium rounded transition-all flex items-center gap-2 disabled:opacity-50 disabled:cursor-not-allowed"
onClick={() => onShowToast('Audio preview coming soon!', 'info')}
disabled
aria-label="Play Preview (Coming Soon)"
>
<span>▶</span> Play Preview
</button>
Expand Down Expand Up @@ -1345,6 +1349,7 @@ export function AISongModal({ isOpen, onClose, onImport, onShowToast, audioEngin
onClick={handleClose}
disabled={isImporting}
className="px-3 sm:px-4 py-2 bg-gray-800 hover:bg-gray-700 text-gray-300 text-xs font-medium rounded transition-all disabled:opacity-50"
aria-label="Cancel Import"
>
<span className="hidden sm:inline">Cancel</span>
<span className="sm:hidden">✕</span>
Expand All @@ -1359,6 +1364,7 @@ export function AISongModal({ isOpen, onClose, onImport, onShowToast, audioEngin
? 'bg-emerald-600 hover:bg-emerald-500 text-white shadow-[0_0_20px_rgba(16,185,129,0.3)] hover:shadow-[0_0_30px_rgba(16,185,129,0.5)]'
: 'bg-gray-700 text-gray-500'
}`}
aria-label="Import AI Song"
>
{isImporting ? (
<>
Expand Down
2 changes: 2 additions & 0 deletions src/components/RbsImportModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@ export function RbsImportModal({ isOpen, onClose, onImport, onShowToast }: RbsIm
onClick={() => fileInputRef.current?.click()}
className="mt-2 px-4 py-2 bg-gray-800 hover:bg-gray-700 text-gray-300 text-xs rounded transition-all"
disabled={isParsing}
aria-label="Browse Files to Import"
>
Browse Files
</button>
Expand Down Expand Up @@ -838,6 +839,7 @@ export function RbsImportModal({ isOpen, onClose, onImport, onShowToast }: RbsIm
onClick={onClose}
disabled={isImporting}
className="px-4 py-2 bg-gray-800 hover:bg-gray-700 text-gray-300 text-xs font-medium rounded transition-all disabled:opacity-50"
aria-label="Cancel Import"
>
Cancel
</button>
Expand Down
Loading