Skip to content

feat(sampler): add Custom Sample Slicing UI with transient visualization and dragging#437

Merged
ford442 merged 2 commits intomainfrom
jules-14867844128597551224-3f076c64
Apr 12, 2026
Merged

feat(sampler): add Custom Sample Slicing UI with transient visualization and dragging#437
ford442 merged 2 commits intomainfrom
jules-14867844128597551224-3f076c64

Conversation

@ford442
Copy link
Copy Markdown
Owner

@ford442 ford442 commented Apr 12, 2026

This PR implements the "Custom Sample Slicing UI" from the agent_plan.md Active Backlog.

Features

  • Interactive Slicing UI: WaveformDisplay now allows users to manually define and manipulate sample slice markers when in stretch mode for the Sampler.
  • Double-Click Interactions: Users can double-click anywhere on the waveform canvas without an existing slice to initialize one covering the entire file, double-click inside an existing slice to split it in two at that point, or double-click near an existing transient marker to merge adjacent slices.
  • Draggable Boundaries: Hovering over a marker changes the cursor to col-resize and clicking and dragging adjusts the boundary between two slices natively.
  • Audio Engine Integration: The useAudioEngine hook now exports a setAlignment function, passed down to SamplerPanel and mapped to onAlignmentChange, bridging the React state update of these boundaries with the underlying PhonemeAligner representations so they function identically to TTS syllables.
  • Roadmap Update: The agent_plan.md has been successfully updated, marking this feature complete and moving the logical next step ("Auto-Slice by Transients") to the Innovation Lab.

Verification

  • Fully verified via pnpm test, pnpm lint, and pnpm build.
  • Merged with main to ensure clean resolution.

PR created automatically by Jules for task 14867844128597551224 started by @ford442

…ion and dragging

- Adds custom transient/marker slicing UI to `WaveformDisplay.tsx`
- Adds ability to double-click to add/remove slice markers
- Adds drag-to-adjust slice boundary handles with explicit hover affordances
- Exposes `setAlignment` from `sampleManagement.ts` audio engine hook to properly pipe the modified manual slice parameters to the audio thread
- Updated `agent_plan.md` to reflect progress and adds new "Auto-Slice by Transients" goal to Innovation Lab

Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ford442 ford442 merged commit da476c2 into main Apr 12, 2026
1 check failed
@ford442 ford442 deleted the jules-14867844128597551224-3f076c64 branch April 12, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant