Skip to content

🎨 Palette: Improve background overlay accessibility in modals#435

Merged
ford442 merged 1 commit intomainfrom
jules-6973499334968866107-85e20dec
Apr 11, 2026
Merged

🎨 Palette: Improve background overlay accessibility in modals#435
ford442 merged 1 commit intomainfrom
jules-6973499334968866107-85e20dec

Conversation

@ford442
Copy link
Copy Markdown
Owner

@ford442 ford442 commented Apr 11, 2026

💡 What: Standardized background overlay implementation for modale dialogs.
🎯 Why: Having onClick bound to the main wrapper or an overlay without aria-hidden="true" causes screen readers to pick up the entire background as an interactive element.
📸 Before/After: Visuals remain unchanged, but the DOM structure ensures the click handler is attached to a hidden sibling of the dialog rather than its parent wrapper.
♿ Accessibility: Ensures assistive technologies ignore the modal backdrop overlay while maintaining its click-to-dismiss behavior.


PR created automatically by Jules for task 6973499334968866107 started by @ford442

Extracted clickable background overlays into distinct `<div aria-hidden="true">` elements across multiple modal components (`AISongModal`, `RbsImportModal`, `VoiceEditor`).

This prevents screen readers from redundantly announcing the empty clickable background area or inappropriately exposing it within the focus/navigation hierarchy, aligning with standard ARIA modal guidelines documented in the codebase.

Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ford442 ford442 merged commit ac6e501 into main Apr 11, 2026
1 check passed
@ford442 ford442 deleted the jules-6973499334968866107-85e20dec branch April 11, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant