🎨 Palette: Cloud Library Modal Accessibility#433
Conversation
Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added standard ARIA modal attributes (
role="dialog",aria-modal="true",aria-labelledby,tabIndex={-1}) to theCloudLibrarymodal component. Also added anaria-hidden="true"to the clickable backdrop.🎯 Why: To standardize modal accessibility across the app, ensuring screen readers announce the
CloudLibrarycorrectly as a dialog with an accessible name, and preventing them from reading the empty clickable background area.📸 Before/After: Visuals remain identical (as intended), but under the hood, the modal is now properly semantic.
♿ Accessibility:
role="dialog",aria-modal="true",tabIndex={-1}<h2>foraria-labelledbyaria-hidden="true"div.PR created automatically by Jules for task 5066101433088462225 started by @ford442