Skip to content

🎨 Palette: Cloud Library Modal Accessibility#433

Merged
ford442 merged 1 commit intomainfrom
Palette-add-cloud-library-modal-a11y-5066101433088462225
Apr 10, 2026
Merged

🎨 Palette: Cloud Library Modal Accessibility#433
ford442 merged 1 commit intomainfrom
Palette-add-cloud-library-modal-a11y-5066101433088462225

Conversation

@ford442
Copy link
Copy Markdown
Owner

@ford442 ford442 commented Apr 10, 2026

💡 What: Added standard ARIA modal attributes (role="dialog", aria-modal="true", aria-labelledby, tabIndex={-1}) to the CloudLibrary modal component. Also added an aria-hidden="true" to the clickable backdrop.

🎯 Why: To standardize modal accessibility across the app, ensuring screen readers announce the CloudLibrary correctly as a dialog with an accessible name, and preventing them from reading the empty clickable background area.

📸 Before/After: Visuals remain identical (as intended), but under the hood, the modal is now properly semantic.

♿ Accessibility:

  • Added role="dialog", aria-modal="true", tabIndex={-1}
  • Added an invisible <h2> for aria-labelledby
  • Separated the clickable backdrop into its own aria-hidden="true" div.

PR created automatically by Jules for task 5066101433088462225 started by @ford442

Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ford442 ford442 merged commit 2e3d7b7 into main Apr 10, 2026
1 check passed
@ford442 ford442 deleted the Palette-add-cloud-library-modal-a11y-5066101433088462225 branch April 10, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant