Fix rendering freeze when loading a new module#118
Merged
Conversation
The cells buffer update effect was using `renderParamsRef.current.matrix` as a React dep — a mutable ref read that can be ambiguous when React evaluates the dependency array. This meant the GPU cells buffer could fail to refresh on module load, leaving stale pattern data on screen. Fix: pass `matrix` and `padTopChannel` as explicit parameters to `useWebGPURender` and use them directly as effect deps. React now reliably detects the new-module identity change and rebuilds the cells buffer and bind group. Same fix applied to the channels buffer effect (matrix?.numChannels → matrix?.numChannels via direct param). https://claude.ai/code/session_01GnHw4NyaiJ3PA7TUzui6t4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cells buffer update effect was using
renderParamsRef.current.matrixas a React dep — a mutable ref read that can be ambiguous when React evaluates the dependency array. This meant the GPU cells buffer could fail to refresh on module load, leaving stale pattern data on screen.Fix: pass
matrixandpadTopChannelas explicit parameters touseWebGPURenderand use them directly as effect deps. React now reliably detects the new-module identity change and rebuilds the cells buffer and bind group. Same fix applied to the channels buffer effect (matrix?.numChannels → matrix?.numChannels via direct param).https://claude.ai/code/session_01GnHw4NyaiJ3PA7TUzui6t4