Skip to content

Ensure unconditional data write for all GPU buffer cells #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ford442 merged 1 commit into from
Mar 26, 2026
Merged

Ensure unconditional data write for all GPU buffer cells #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions mod-player-shaders/hooks/useGPUBuffers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ export const packPatternMatrix = (matrix: PatternMatrix | null, padTopChannel =
let volVal = 0;
let effCmd = 0;
let effVal = 0;
let wordB = 0;

if (cell) {
// First try numeric fields (from getPatternMatrix)
Expand All @@ -114,6 +115,7 @@ export const packPatternMatrix = (matrix: PatternMatrix | null, padTopChannel =
volVal = cell.volVal || 0;
effCmd = cell.effCmd || 0;
effVal = cell.effVal || 0;
wordB = ((effCmd & 0xFF) << 8) | (effVal & 0xFF);
}
// Fall back to parsing text if available
else if (cell.text && cell.text.trim()) {
Expand All @@ -123,15 +125,13 @@ export const packPatternMatrix = (matrix: PatternMatrix | null, padTopChannel =
const instMatch = text.match(/(\d{1,3})$/);
inst = instMatch?.[1] ? Math.min(255, parseInt(instMatch[1], 10)) : 0;
note = encodeNoteText(notePart);
packed[offset + 1] = parsePackedB(text) >>> 0;
wordB = parsePackedB(text) >>> 0;
}
}

// Always write packed data for this cell position
packed[offset] = ((note & 0xFF) << 24) | ((inst & 0xFF) << 16) | ((volCmd & 0xFF) << 8) | (volVal & 0xFF);
if (!cell?.text) {
packed[offset + 1] = ((effCmd & 0xFF) << 8) | (effVal & 0xFF);
}
packed[offset + 1] = wordB;
}
}
return packed;
Expand Down
Loading