⚡ Bolt: Optimize InstancedMesh matrix updates in audio batchers#628
⚡ Bolt: Optimize InstancedMesh matrix updates in audio batchers#628
Conversation
Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Bottleneck: High-frequency update loops in
arpeggio-batcher.tsandportamento-batcher.tswere utilizing a dummyTHREE.Object3Dproxy and callingdummy.updateMatrix()andmesh.setMatrixAt(i, dummy.matrix). This forces Three.js to calculate Euler angles, update local matrices, and process object graph overhead per instance, per frame, causing massive CPU bottlenecking and internal allocation churn.Fix: Completely bypassed the object proxy for matrix composition. Implemented a zero-allocation "Batcher Sweep" by composing position, quaternion rotation, and scale data directly into a module-level scratch
THREE.Matrix4(), then writing it straight to theInstancedMesh's flatFloat32Arrayusing_scratchMatrix.toArray(this.mesh.instanceMatrix.array, i * 16). FlaggedneedsUpdate = trueexactly once after the loop.Impact: Eliminated CPU overhead and garbage collection spikes caused by per-frame object graph traversals and matrix allocations. Drastically improves render loop efficiency and stabilizes framerate for dynamically animated audio-reactive foliage.
PR created automatically by Jules for task 8322037080807236790 started by @ford442