Conversation
…ctiveLoading` function in `src/systems/asset-streaming/asset-streaming.ts` to use a zero-allocation approach. Replaced the `THREE.Vector3` object instantiations (`.clone()`) and chaining with a globally shared `_scratchFuturePos` scratch vector. This resolves Garbage Collection (GC) spikes and frame drops during predictive asset streaming inside the main game loop. Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Bottleneck: "Was allocating
THREE.Vector3instances per frame via.clone()and math chaining insideupdatePredictiveLoading, causing GC spikes and frame drops during streaming operations."\n\nFix: "Implemented a shared_scratchFuturePosTHREE.Vector3scratch variable at the module level. Restructured the predictive math to utilize in-place mutation methods (.copy,.multiplyScalar,.add) to achieve a zero-allocation footprint within the hot path."\n\nImpact: "Eliminated per-frame object instantiations in predictive loading, significantly reducing GC pressure and stabilizing framerate while maintaining seamless continuous asset streaming."PR created automatically by Jules for task 9265640054029750759 started by @ford442