Skip to content

⚡ Bolt: Batcher Sweep Matrix Optimization #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ford442 merged 1 commit into from
Apr 9, 2026
+20 −10
Merged

⚡ Bolt: Batcher Sweep Matrix Optimization #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/foliage/arpeggio-batcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { mergeGeometries } from 'three/addons/utils/BufferGeometryUtils.js';

const MAX_FERNS = 2000;
const FRONDS_PER_FERN = 5;
const _scratchMatrix = new THREE.Matrix4();

export class ArpeggioFernBatcher {
initialized: boolean;
Expand Down Expand Up @@ -332,9 +333,10 @@ export class ArpeggioFernBatcher {
// So I just need to copy dummy position/rotation/scale.
this.dummy.rotation.copy(dummy.rotation);
this.dummy.scale.setScalar(scale);
this.dummy.updateMatrix();

this.mesh!.setMatrixAt(i, this.dummy.matrix);
// ⚡ OPTIMIZATION: Eliminate CPU overhead and GC spikes from Matrix4 composition by writing directly to instanceMatrix.array
_scratchMatrix.compose(this.dummy.position, this.dummy.quaternion, this.dummy.scale);
_scratchMatrix.toArray(this.mesh!.instanceMatrix.array, i * 16);

// Color
this._color.setHex(color);
Expand All @@ -353,9 +355,11 @@ export class ArpeggioFernBatcher {
this.dummy.position.copy(dummy.position);
this.dummy.rotation.copy(dummy.rotation);
this.dummy.scale.copy(dummy.scale);
this.dummy.updateMatrix();

this.mesh!.setMatrixAt(index, this.dummy.matrix);
// ⚡ OPTIMIZATION: Eliminate CPU overhead and GC spikes from Matrix4 composition by writing directly to instanceMatrix.array
_scratchMatrix.compose(this.dummy.position, this.dummy.quaternion, this.dummy.scale);
_scratchMatrix.toArray(this.mesh!.instanceMatrix.array, index * 16);

this.mesh!.instanceMatrix.needsUpdate = true;
}

Expand Down
18 changes: 12 additions & 6 deletions src/foliage/portamento-batcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
} from 'three/tsl';

const MAX_PINES = 200; // conservative default for performance
const _scratchMatrix = new THREE.Matrix4();

export class PortamentoPineBatcher {
initialized = false;
Expand Down Expand Up @@ -171,10 +172,12 @@ export class PortamentoPineBatcher {
this.dummy.position.copy(dummy.position);
this.dummy.quaternion.copy(dummy.quaternion);
this.dummy.scale.copy(dummy.scale);
this.dummy.updateMatrix();

this.trunkMesh!.setMatrixAt(i, this.dummy.matrix);
this.needleMesh!.setMatrixAt(i, this.dummy.matrix);
// ⚡ OPTIMIZATION: Eliminate CPU overhead and GC spikes from Matrix4 composition by writing directly to instanceMatrix.array
_scratchMatrix.compose(this.dummy.position, this.dummy.quaternion, this.dummy.scale);
_scratchMatrix.toArray(this.trunkMesh!.instanceMatrix.array, i * 16);
_scratchMatrix.toArray(this.needleMesh!.instanceMatrix.array, i * 16);

this.bendAttribute!.setX(i, 0);

this.trunkMesh!.instanceMatrix.needsUpdate = true;
Expand All @@ -191,9 +194,12 @@ export class PortamentoPineBatcher {
this.dummy.position.copy(dummy.position);
this.dummy.quaternion.copy(dummy.quaternion);
this.dummy.scale.copy(dummy.scale);
this.dummy.updateMatrix();
this.trunkMesh!.setMatrixAt(idx, this.dummy.matrix);
this.needleMesh!.setMatrixAt(idx, this.dummy.matrix);

// ⚡ OPTIMIZATION: Eliminate CPU overhead and GC spikes from Matrix4 composition by writing directly to instanceMatrix.array
_scratchMatrix.compose(this.dummy.position, this.dummy.quaternion, this.dummy.scale);
_scratchMatrix.toArray(this.trunkMesh!.instanceMatrix.array, idx * 16);
_scratchMatrix.toArray(this.needleMesh!.instanceMatrix.array, idx * 16);

this.trunkMesh!.instanceMatrix.needsUpdate = true;
this.needleMesh!.instanceMatrix.needsUpdate = true;
}
Expand Down
Loading