This repository was archived by the owner on Feb 12, 2022. It is now read-only.
Namespace fix#34
Open
tfuda wants to merge 2 commits intoforcedotcom:masterfrom
patronmanager:NamespaceFix
Open
Namespace fix#34tfuda wants to merge 2 commits intoforcedotcom:masterfrom patronmanager:NamespaceFix
tfuda wants to merge 2 commits intoforcedotcom:masterfrom
patronmanager:NamespaceFix
Conversation
added 2 commits
March 2, 2016 08:10
Collaborator
|
@tfuda I observed that it failed again. Let me take a look at this. |
Collaborator
|
@pmedapuram I believe you handled this change in your other PR(s). Can you please confirm? |
Contributor
|
@dragon0556 please follow up with @pmedapuram to see if this should be closed @ashwin512 FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resoves #30 by splitting the regex on the . character to extract the namespace