fix(image): handle long filenames on macOS with hash #2604
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, file names longer than 255 characters are not supported. This change checks if the source file name exceeds this limit and, if so, uses a hash of the source and page as the cache file name. This prevents errors when dealing with very long file names. hange checks if the source file name exceeds this limit and, if so, uses a hash of the source and page as the cache file name. This prevents errors when dealing with very long file names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On macOS, file names longer than 255 characters are not supported. This change checks if the source file name exceeds this limit and, if so, uses a hash of the source and page as the cache file name. This prevents errors when dealing with very long file names.
hange checks if the source file name exceeds this limit and, if so, uses a hash of the source and page as the cache file name. This prevents errors when dealing with very long file names.
Related issue
#2506
Screenshots