UIU-3499: Handle an undefined of assignedRoleIds in UserRolesModal. Clear cache after roles update to avoid displaying stale data (follow-up).
#3001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dmytro-Melnyshyn
force-pushed
the
UIU-3499
branch
from
54076bb to
b44871b
Compare
Dmytro-Melnyshyn
changed the title
assignedRoleIds in UserRolesModal. Clear update cache after roles update to avoid displaying incorrect data (follow-up).assignedRoleIds in UserRolesModal. Clear cache after roles update to avoid displaying incorrect data (follow-up).
Dmytro-Melnyshyn
changed the title
assignedRoleIds in UserRolesModal. Clear cache after roles update to avoid displaying incorrect data (follow-up).assignedRoleIds in UserRolesModal. Clear cache after roles update to avoid displaying stale data (follow-up).
Dmytro-Melnyshyn
force-pushed
the
UIU-3499
branch
2 times, most recently
from
2738652 to
76797d0
Compare
…lear update cache after roles update to avoid displaying incorrect data.
Dmytro-Melnyshyn
force-pushed
the
UIU-3499
branch
from
76797d0 to
de2c81b
Compare
|
vashjs
approved these changes
Dec 29, 2025
Dmitriy-Litvinenko
approved these changes
Dec 29, 2025
Dmytro-Melnyshyn
added a commit
that referenced
this pull request
Dec 29, 2025
…lear update cache after roles update to avoid displaying incorrect data. (#3001)
zburke
reviewed
Dec 29, 2025
Member
zburke
left a comment
zburke
left a comment
There was a problem hiding this comment.
These changes look fine, though I don't see how assignedRoleIds was ever undefined; it's initialized to an empty object so the swap from
assignedRoleIds[tenantId] ? assignedRoleIds[tenantId].concat(id) : [id]
to
(assignedRoleIds[tenantId] || []).concat(id)
should not have had any effect. Am I missing something?
Please address Sonar's complaint before you merge to avoid adding new tech-debt.
Comment on lines
-72
to
+87
| }).catch(sendErrorCallout); | ||
| }) | ||
| .then(async () => { | ||
| await queryClient.invalidateQueries({ queryKey: [namespace, userId, tenantIdKey] }); | ||
| }) | ||
| .catch(sendErrorCallout); |
Member
There was a problem hiding this comment.
Sonar is grumpy about how deeply nested this is. Let's convert it all to async/await instead of mixing that with promise chaining. I think that'll satisfy Sonar, and it'll be more consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Issues
https://folio-org.atlassian.net/browse/UIU-3499
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.