m-3400-3

[Dmytro-Melnyshyn]

Purpose

1. A user expires earlier for the Vancouver time zone.
2. When the "Reset" button is hit, it should add the correct number of days.

Approach

1. Remove UTC for expiration date. The UTC was added relatively recently to display the same date for all time zones, which was not correct with the original design and caused the incorrect expiration of users.
2. Use .format() instead of .format('L') to preserve timezone information in the ISO string. .format('L') produces a local date string like "08/31/2025" which loses timezone context, causing parseExpirationDate to incorrectly interpret the date and shift it by a day. .format() produces an ISO string like "2025-08-31T02:59:59+03:00" that maintains timezone.

Screencasts

1. For the first issue

2. For the second issue

2025-08-29_13h13_06.mp4

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

• I've added appropriate record to the CHANGELOG.md
• Does this PR meet or exceed the expected quality standards?
  • Code coverage on new code is 80% or greater
  • Duplications on new code is 3% or less
  • There are no major code smells or security issues
• Does this introduce breaking changes?
  • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
  • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

• What other modules will these changes impact?
• Do JIRAs exist to update the impacted modules?
  • If not, please create them
  • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
  • Do they have all they appropriate links to blocked/related issues?
• Are the JIRAs under active development?
  • If not, contact the project's PO and make sure they're aware of the urgency.
• Do PRs exist for these changes?
  • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

[github-actions]

Jest Unit Test Results

    1 files  ±0    273 suites  ±0   5m 50s ⏱️ +7s
1 297 tests ±0  1 294 ✅ ±0  3 💤 ±0  0 ❌ ±0 
1 338 runs  ±0  1 335 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit 5eaeb18. ± Comparison against base commit 7ac65e0.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud