UIU-2431 create JEST/RTL test cases for UserSearch.js #2449
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
zburke
left a comment
zburke
left a comment
There was a problem hiding this comment.
16/20 tests here end by taking some action without a follow-up expect call to validate that something happened as a result of that action. This validates that the function was callable, but that's it: it doesn't establish that the function behaves correctly.
Maybe you need to add assertions that a "submit" button is disabled until required fields have been filled out, and then assert that that it's enabled when they are completed, and then assert that clicking the button causes it to to disappear (presumably because the modal containing it closes, which is something else you could assert). Maybe you need to mock an API so you can assert that when somebody types 3/12/2023 into a date-field and then hits "Save" it closes the modal and makes an API request to some-report?query=startDate=2023-03-12. etc. etc.
|
Kudos, SonarCloud Quality Gate passed!
|
UIU-2431 create JEST/RTL test cases for UserSearch.js
URL: https://issues.folio.org/browse/UIU-2431