Skip to content

MODSOURMAN-1399 - Properly handle the failed result of the request for snapshot creation #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RuslanLavrov wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MODSOURMAN-1399 - Properly handle the failed result of the request for snapshot creation #1017

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d163cd
Properly handle failed result of request for snapshot creation
RuslanLavrov Mar 3, 2026
0d356f5
Merge branch 'master' of github.com:folio-org/mod-source-record-manag…
RuslanLavrov Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions ...ource-record-manager-server/src/main/java/org/folio/services/JobExecutionServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,12 +591,15 @@ private Future<String> postSnapshot(Snapshot snapshot, OkapiConnectionParams par

SourceStorageSnapshotsClient client = new SourceStorageSnapshotsClient(params.getOkapiUrl(), params.getTenantId(), params.getToken());
try {
client.postSourceStorageSnapshots(snapshot, response -> {
if (response.result().statusCode() != HttpStatus.HTTP_CREATED.toInt()) {
LOGGER.warn("postSnapshot:: Error during post for new Snapshot. Status message: {}", response.result().statusMessage());
promise.fail(new HttpException(response.result().statusCode(), "Error during post for new Snapshot."));
return client.postSourceStorageSnapshots(snapshot)
.onFailure(e -> LOGGER.warn("postSnapshot:: Error during post for new Snapshot", e))
.compose(response -> {
if (response.statusCode() != HttpStatus.HTTP_CREATED.toInt()) {
LOGGER.warn("postSnapshot:: Error during post for new Snapshot. Status code: {}, body: '{}'",
response.statusCode(), response.bodyAsString());
return Future.failedFuture(new HttpException(response.statusCode(), "Error during post for new Snapshot."));
} else {
promise.complete(response.result().bodyAsString());
return Future.succeededFuture(response.bodyAsString());
}
});
} catch (Exception e) {
Expand Down