[MODINVOICE-632] Cancel invoice: new validation for linked poline budgets

[damien-git]

Purpose

MODINVOICE-632 - Voided transactions are created after cancelling an approved or paid invoice when different funds are used in the PO line and the invoice line

Approach

• New validation step before cancelling an invoice: make sure budgets from linked po lines are active.
• Fixed an issue caused by MODINVOICE-613 and breaking MODINVOICE-360 - some encumbrances were being unreleased when they should not have been.

Note: in some rare cases, an error will happen unnecessarily. For instance: if an encumbrance is already pending, or if it already has a pending payment or payment with another invoice - in that case the encumbrance would not be unreleased, so there would be no issue with the budget being inactive.

Related PR

integration test

---

Pre-Review Checklist

• Self-reviewed Code — Reviewed code for issues, unnecessary parts, and overall quality.
• Change Notes — NEWS.md updated with clear description and issue key.
• Testing — Confirmed changes were tested locally or on dev environment.
• Logging: Confirmed that logging is appropriately handled.
• Breaking Changes — Handled all required actions if changes affect API, DB, or interface versions.
  • API/schema changes
  • Interface version updates
  • DB schema changes / migration scripts
• New Properties / Environment Variables — Updated README.md if new configs were added.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
93.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud