Skip to content

MODDCB-257 Implement DCB transaction expiry and Setting API for it#239

Merged
pfilippov-epam merged 10 commits intomasterfrom
MODDCB-257
Feb 24, 2026
Merged

MODDCB-257 Implement DCB transaction expiry and Setting API for it#239
pfilippov-epam merged 10 commits intomasterfrom
MODDCB-257

Conversation

@pfilippov-epam
Copy link
Contributor

@pfilippov-epam pfilippov-epam commented Feb 20, 2026

Purpose

  1. Adds transaction expiry for the non-lender roles.
  2. Provides an ability to close expired transactions for non-lender roles
  3. Provides more convenient and customizable approach for hold shelf expiry for lender and borrower roles (for Virtual Service Points)
  4. Add integration and unit tests

Approach

  • Implement Settings API
  • Adjust the code base to use settings and then existing configuration for virtual service points hold shelf expiry configuration
  • Extend unit and integration tests

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MODDCB-257
List any Jira issues related to this pull request.

Learning and Resources (if applicable)

Discuss any research conducted during the development of this pull request. Include links to relevant blog posts, patterns, libraries, or addons that were used to solve the problem.

Screenshots (if applicable)

If this pull request involves any visual changes or new features, consider including screenshots or GIFs to illustrate the changes.

@pfilippov-epam pfilippov-epam requested a review from a team as a code owner February 20, 2026 18:27
@sonarqubecloud
Copy link

@pfilippov-epam pfilippov-epam merged commit 11f16fd into master Feb 24, 2026
18 checks passed
@pfilippov-epam pfilippov-epam deleted the MODDCB-257 branch February 24, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants