CIRC-2550 Fix circulation log showing incorrect source for loan renewals#1663
Open
zakletskyi-epam wants to merge 3 commits intomasterfrom
Open
CIRC-2550 Fix circulation log showing incorrect source for loan renewals#1663zakletskyi-epam wants to merge 3 commits intomasterfrom
zakletskyi-epam wants to merge 3 commits intomasterfrom
Conversation
6b648bf to
aeb8a43
Compare
b548e75 to
b1d498e
Compare
pfilippov-epam
approved these changes
Mar 3, 2026
94b1142 to
02750de
Compare
02750de to
278360a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



CIRC-2550
Purpose
When a loan was renewed by one staff member but originally checked out by another, the Circulation Log incorrectly displayed the checkout staff as the source of the renewal action. This happened because the renewal event was published using the loan's
metadata.updatedByUserId(set at checkout time) rather than the ID of the staff member who actually performed the renewal.Approach
Instead of reusing the existing
publishDueDateChangedEvent(which reads the source from loan metadata), a dedicatedpublishRenewedEventmethod was introduced. This method explicitly passes theloggedInUserIdfrom theRenewalContextas theupdatedByUserIdin the log record, ensuring the Circulation Log reflects the staff member who performed the renewal. A unit test was added to verify that the renewal log entry carries the renewal staff ID and not the checkout staff ID.TODOS and Open Questions
Learning