FOLSPRINGS-217 Implement connection pool settings#292
FOLSPRINGS-217 Implement connection pool settings#292pfilippov-epam wants to merge 4 commits intomasterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @Bean | ||
| @Qualifier("dataSourceSchemaAdvisorBeanPostProcessor") | ||
| public static BeanPostProcessor dataSourceSchemaAdvisorBeanPostProcessor( | ||
| @Autowired FolioModuleMetadata moduleMetadata, |
Check notice
Code scanning / SonarCloud
Injecting data into static fields is not supported by Spring
|
| @Bean | ||
| @Qualifier("dataSourceSchemaAdvisorBeanPostProcessor") | ||
| public static BeanPostProcessor dataSourceSchemaAdvisorBeanPostProcessor( | ||
| @Autowired FolioModuleMetadata moduleMetadata, |
Check notice
Code scanning / SonarCloud
Injecting data into static fields is not supported by Spring
pfilippov-epam
force-pushed
the
FOLIO-4381
branch
from
88c01f5 to
8f6a80a
Compare
pfilippov-epam
requested review from
OleksiiKuzminov,
dmtkachenko,
mukhiddin-yusuf,
psmagin,
vgema and
viacheslavkol
psmagin
left a comment
psmagin
left a comment
There was a problem hiding this comment.
Will be good to have it described somewhere in README.
What will happen if module defines this settings in module's application properties, what will have higher priority this ones or module's ones. Would be nice to describe it also in doc
folio-spring-base/src/main/java/org/folio/spring/config/properties/FolioDatabaseEnvs.java
Show resolved
Hide resolved
pfilippov-epam
changed the title
pfilippov-epam
force-pushed
the
FOLIO-4381
branch
from
0efff5d to
1c319c0
Compare
...ing-base/src/main/java/org/folio/spring/config/DataSourceSchemaAdvisorBeanPostProcessor.java
Outdated
Show resolved
Hide resolved
- Update NEWS.md - Enrich documentation
pfilippov-epam
force-pushed
the
FOLIO-4381
branch
from
8764894 to
2b27801
Compare
|
6 participants
Purpose
Implement database configuration settings similar to https://github.com/folio-org/raml-module-builder?tab=readme-ov-file#environment-variables
Jira issues:
Approach
This is a draft PR suggesting the approach where the following configuration properties will update the HikariConfig pool settings:
TODOS and Open Questions
Learning
Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.