MSVC2013 compatibility, sign warnings, headers #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add note that MSVC2019 works
prefer modern cmake GLVND OpenGL PREFERENCE
CMakeLists typo
… arnholm_maint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the great library, now used in https://github.com/arnholm/xcsg
These updates to make carve compatible with MSVC2013 and also g++ 7.3.0 under Ubuntu 18.04
carve now compiler under MSVC2013 and g++ 7.3.0 on linux with few or no warnings. The changes to carve have been tested using xcsg (several examples), no issues.